Fix LT-22267: Slow response in interlinear combos#445
Merged
Conversation
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3)
Src/LexText/Interlinear/ChooseAnalysisHandler.cs line 9 at r1 (raw file):
using System.Linq; using System.Windows.Forms; using Paratext.BibleInfo;
I'd check the using list, looks like some cruft snuck in.
jasonleenaylor
approved these changes
Aug 20, 2025
jasonleenaylor
left a comment
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
jasonleenaylor
pushed a commit
that referenced
this pull request
Sep 19, 2025
* Fix LT-22267: Slow response in interlinear combos * Remove unused using # cherry-picked from c531282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a critical performance issue in the combo box. It was sometimes taking 4-14 seconds to show the menu of possible analyses. The problem was sorting the glosses. This was expensive because it happened once per analysis, and it required scanning all of the interlinear texts to get the context needed for the sort. If a word had 28 analyses, this was very expensive. I decided that it wasn't necessary to sort the glosses: sorting the analyses was enough.
This change is